feat(ffi): FFI boundary with Protobuf wire format (closes #6, #11) #13

Merged

yorunikakeru merged 6 commits from feat/ffi-protobuf-boundary into main

2026-06-17 16:03:45 +02:00

yorunikakeru commented

2026-06-17 15:59:53 +02:00

Owner

Summary

Implements issues #6 and #11 as a single pass — FFI C ABI built directly with Protobuf, skipping the intermediate JSON FFI step.

proto/planner.proto — source of truth for the FFI contract (SystemState, Plan, PlanStep, PlanError, PlanResult oneof)
Planner.Proto — encode/decode between native Haskell types and proto-lens generated types; IR.Action fields embedded as JSON bytes (frogos-ir owns those instances)
Planner.FFI — hs_planner_init, hs_plan, hs_plan_free foreign exports compiled as libplanner-ffi.so via foreign-library native-shared
Breaking: SystemState and Plan lose manual version fields; versioning moves to proto field numbering
Breaking: ToJSON/FromJSON instances removed from Planner.Types; JSON golden tests replaced with proto round-trip tests

C ABI (for Rust `extern "C"`)

void hs_planner_init(void);
int  hs_plan(const char *ir_ptr, int ir_len,
             const char *state_ptr, int state_len,
             char **out_ptr, int *out_len);  // 0=ok, 1=decode error
void hs_plan_free(char *ptr);

Input: IR document as JSON bytes (from frogos-ir) + SystemState as proto bytes.
Output: PlanResult as proto bytes (caller copies, then calls hs_plan_free).

Test plan

cabal test — 19 tests pass (proto round-trips + all existing Core tests)
cabal build planner-ffi — libplanner-ffi.so.0 links cleanly
nm -D libplanner-ffi.so | grep hs_plan — all three symbols exported with T
Integration test against Rust caller (tracked in #7)

## Summary Implements issues #6 and #11 as a single pass — FFI C ABI built directly with Protobuf, skipping the intermediate JSON FFI step. - **`proto/planner.proto`** — source of truth for the FFI contract (`SystemState`, `Plan`, `PlanStep`, `PlanError`, `PlanResult` oneof) - **`Planner.Proto`** — encode/decode between native Haskell types and proto-lens generated types; `IR.Action` fields embedded as JSON bytes (frogos-ir owns those instances) - **`Planner.FFI`** — `hs_planner_init`, `hs_plan`, `hs_plan_free` foreign exports compiled as `libplanner-ffi.so` via `foreign-library native-shared` - **Breaking:** `SystemState` and `Plan` lose manual version fields; versioning moves to proto field numbering - **Breaking:** `ToJSON`/`FromJSON` instances removed from `Planner.Types`; JSON golden tests replaced with proto round-trip tests ## C ABI (for Rust `extern "C"`) ```c void hs_planner_init(void); int hs_plan(const char *ir_ptr, int ir_len, const char *state_ptr, int state_len, char **out_ptr, int *out_len); // 0=ok, 1=decode error void hs_plan_free(char *ptr); ``` Input: IR document as JSON bytes (from frogos-ir) + `SystemState` as proto bytes. Output: `PlanResult` as proto bytes (caller copies, then calls `hs_plan_free`). ## Test plan - [ ] `cabal test` — 19 tests pass (proto round-trips + all existing Core tests) - [ ] `cabal build planner-ffi` — `libplanner-ffi.so.0` links cleanly - [ ] `nm -D libplanner-ffi.so | grep hs_plan` — all three symbols exported with `T` - [ ] Integration test against Rust caller (tracked in #7)

yorunikakeru added 6 commits

2026-06-17 15:59:53 +02:00

feat(ffi): add planner.proto schema (SystemState, Plan, PlanError, PlanResult) 9fd37e70fe

build: add proto-lens 0.7 deps, foreign-library stanza, proto devtools in devShell dee00f60aa

build: commit proto-lens generated Proto.Planner + Proto.Planner_Fields; add Planner.Proto stub 74a327c0f0

feat(proto): implement Planner.Proto codec with SystemState/Plan/PlanError round-trips 053540df24

refactor(types): remove version fields and Aeson instances from Planner.Types b7d488cc41

feat(ffi): add hs_plan/hs_plan_free/hs_planner_init C ABI with proto wire format

CI / linux (pull_request) Failing after 1m19s

Details

80f80823a7