ux: human-readable diagnostics (issue #32) #38

Merged

yorunikakeru merged 3 commits from feature/issue-32-human-readable-diagnostics into main 2026-06-15 13:35:29 +02:00

Conversation 0 Commits 3 Files changed 10 +110 -21

yorunikakeru commented 2026-06-15 13:33:41 +02:00

Owner

Copy link

Summary

• Adds DSL.Diagnostics.renderValidationError :: ValidationError -> Text — human-readable message per constructor
• Updates DSL.Compile.compileResult to use renderDomainError (IR) and renderValidationError instead of show dumps
• Removes dead Int index field from Location — type now honestly reflects what it carries

Before:

validation error: AtSection (Location ProfileKind 0 "gaming") (IntraConflict "docker")

After:

profile "gaming": service "docker" is both enabled and disabled

IR changes (in separate IR commit 37933a6): renderDomainError added to IR.Domain.Error; all FromJSON parsers replaced fail . show with fail . T.unpack . renderDomainError.

Test Plan

• DSL.DiagnosticsSpec — 7 unit tests, one per ValidationError constructor
• DSL.CompileSpec — 2 new cases asserting exact human-readable message strings
• DSL.ValidateSpec — existing tests updated to match new Location shape; all pass
• nix flake check passes

Closes #32

## Summary - Adds `DSL.Diagnostics.renderValidationError :: ValidationError -> Text` — human-readable message per constructor - Updates `DSL.Compile.compileResult` to use `renderDomainError` (IR) and `renderValidationError` instead of `show` dumps - Removes dead `Int` index field from `Location` — type now honestly reflects what it carries **Before:** ``` validation error: AtSection (Location ProfileKind 0 "gaming") (IntraConflict "docker") ``` **After:** ``` profile "gaming": service "docker" is both enabled and disabled ``` IR changes (in separate IR commit `37933a6`): `renderDomainError` added to `IR.Domain.Error`; all `FromJSON` parsers replaced `fail . show` with `fail . T.unpack . renderDomainError`. ## Test Plan - [x] `DSL.DiagnosticsSpec` — 7 unit tests, one per `ValidationError` constructor - [x] `DSL.CompileSpec` — 2 new cases asserting exact human-readable message strings - [x] `DSL.ValidateSpec` — existing tests updated to match new `Location` shape; all pass - [x] `nix flake check` passes Closes #32

yorunikakeru added 3 commits 2026-06-15 13:33:41 +02:00

feat(diagnostics): add renderValidationError c6b9ac5f47

feat(compile): human-readable errors; strengthen CompileSpec ... dc09966aa1

compileResult now calls renderDomainError and renderValidationError
instead of show. CompileSpec asserts exact message strings.

refactor(validate): remove dead index field from Location d1e4251fc2

yorunikakeru merged commit 9e95dfd00b into main 2026-06-15 13:35:29 +02:00

yorunikakeru referenced this pull request from a commit 2026-06-15 13:35:30 +02:00

Merge pull request 'ux: human-readable diagnostics (issue #32)' (#38) from feature/issue-32-human-readable-diagnostics into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

FrogOS/DSL!38

No description provided.