bug: second sequential `when` in a profile silently re-scopes earlier actions under the new condition #30

New issue

Closed

opened 2026-06-11 15:38:22 +02:00 by yorunikakeru · 0 comments

yorunikakeru commented

2026-06-11 15:38:22 +02:00

Owner

DSL.Builder.when` (src/DSL/Builder.hs:74-78) overwrites `ssCondition` on the accumulated section state and keeps already-collected actions:

profile "p" $ do
  when condA $ disable "docker"   -- state: cond=A, actions=[disable docker]
  when condB $ disable "bluetooth" -- state: cond=B (A discarded!), actions=[disable docker, disable bluetooth]

Result: ProfileSection with condition B and both actions — `disable "docker"` is now silently gated on condB, condA vanishes. Same family as closed #23 (nested when), but the nested case is now a type error via scopes while the sequential case still type-checks and miscompiles intent.

BuilderSpec has no test with two `when` calls in one profile.

Fix options:

error in `when` if `ssCondition` is already `Just` (fail-fast, matches Builder philosophy), or
make profile hold `[(Maybe Condition, [Action])]` groups so each when scopes only its own body (bigger IR change).

First option is the minimal correct one.

DSL.Builder.when\` (src/DSL/Builder.hs:74-78) overwrites \`ssCondition\` on the accumulated section state and keeps already-collected actions: ```haskell profile "p" $ do when condA $ disable "docker" -- state: cond=A, actions=[disable docker] when condB $ disable "bluetooth" -- state: cond=B (A discarded!), actions=[disable docker, disable bluetooth] ``` Result: ProfileSection with condition B and **both** actions — \`disable "docker"\` is now silently gated on condB, condA vanishes. Same family as closed #23 (nested when), but the nested case is now a type error via scopes while the *sequential* case still type-checks and miscompiles intent. BuilderSpec has no test with two \`when\` calls in one profile. Fix options: - error in \`when\` if \`ssCondition\` is already \`Just\` (fail-fast, matches Builder philosophy), or - make profile hold \`[(Maybe Condition, [Action])]\` groups so each when scopes only its own body (bigger IR change). First option is the minimal correct one.

yorunikakeru self-assigned this

2026-06-13 23:03:39 +02:00

yorunikakeru referenced this issue from a commit

2026-06-15 13:47:18 +02:00

fix(builder): reject second when in same profile

yorunikakeru referenced this issue from a pull request that will close it,

2026-06-15 13:53:27 +02:00

fix(builder): reject second when in same profile #39

yorunikakeru closed this issue

2026-06-15 13:54:55 +02:00